Assign -Wno-keyword-compat to clang only
#35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compiler flag `-Wno-keyword-compat` is not recognized by GCC, but by clang. Although it does not harm the resulting compilation unit (GCC has a special handling of `-Wno-*` flags), an additional warning message is issued if a compilation unit fails or produces other warnings: ``` At global scope: cc1plus: note: unrecognized command-line option '-Wno-keyword-compat' may have been intended to silence earlier diagnostics ``` This commit assigns `-Wno-keyword-compat` to clang only. Signed-off-by: Simon Kuenzer <simon@unikraft.io>
mschlumpp
approved these changes
Aug 31, 2023
StefanJum
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
All good, thanks.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
razvand
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler flag
-Wno-keyword-compatis not recognized by GCC, but by clang. Although it does not harm the resulting compilation unit (GCC has a special handling of-Wno-*flags), an additional warning message is issued if a compilation unit fails or produces other warnings (tested with GCC 13.2):This PR assigns
-Wno-keyword-compatto clang only.