Fix unwinding #11
Fix unwinding #11
Conversation
|
Thanks for the quick fix @mschlumpp . I confirm it works on Debian Bookworm! |
|
Is there anything pending before we can merge this? Would love to use it already, without having to point to the fork |
There was a problem hiding this comment.
This works fine @mschlumpp, thanks.
Please author the commit using the same email address that you use for the SOB (it's authored by <marco.schlumpp@gmail.com> now).
I would also add a bit more descriptive commit message, Fix unwinding is too general.
The patch just skipped internal libunwind functions to work-around the missing unwind tables in libunwind itself. This work-around caused a mismatch between the actual stack state and what the unwind tables of the user application expected. Signed-off-by: Marco Schlumpp <marco@unikraft.io>
libunwind has to unwind its own functions too when unwinding the complete stack. Without unwind tables this is impossible. Therefore, enable them for libunwind itself. Signed-off-by: Marco Schlumpp <marco@unikraft.io>
mschlumpp
force-pushed
the
mschlumpp/fix/unwinding-patch
branch
from
859ae5c
to
eb4bb16
Compare
There was a problem hiding this comment.
All good now, thanks.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
There was a problem hiding this comment.
It's the second time we are removing this patch, hopefully this time for good! The changes are alright, thanks @mschlumpp!
Reviewed-by: Maria Sfiraiala maria.sfiraiala@gmail.com
|
Not that it needs to happen right now, but out of curiosity, how do changes to |
@jviotti , currently, when we do a release we switch things to stable, once we have tested everything. The goal would be that, in the not-so-far term, we would be able to have an automated transition of In case of certain commits / PRs, we can do manual testing and then make their transition to |
|
Makes sense!
No worries, |
libunwind has to unwind its own functions too when unwinding the complete stack. Without unwind tables this is impossible. Therefore, enable them for libunwind itself. Also remove the patch which just skipped those internal libunwind functions to work-around the missing unwind tables. This work-around caused a mismatch between the actual stack state and what the unwind tables of the user application expected.