Correct libc dependency #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
StefanJum
suggested changes
Aug 6, 2023
There was a problem hiding this comment.
This looks good @andreittr, please add Config.uk: as the component in the commit message.
RaduNichita
approved these changes
Aug 6, 2023
There was a problem hiding this comment.
All good also from my side. Thanks, @andreittr
I have no other comment besides what @StefanJum has already said.
Reviewed-by: Radu Nichita radunichita99@gmail.com
Previously libuuid would hard-select libnewlibc as it requires a libc. This change eases this restriction into a dependency on any libc. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
andreittr
force-pushed
the
ttr/no-newlibc
branch
from
73f1135
to
881f854
Compare
|
The discussion on |
StefanJum
approved these changes
Aug 11, 2023
There was a problem hiding this comment.
We can keep the config dependency since it's a simple one, as discussed here
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
razvand
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously libuuid would hard-select libnewlibc as it requires a libc.
This change eases this restriction into a dependency on any libc.