Adapt forced polling mode to uknetdev flag rename #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razvand
approved these changes
Feb 4, 2023
There was a problem hiding this comment.
Hi, @mschlumpp. This is OK with me. Maybe you want to use your @unikraft.io e-mail address.
@skuenzer, please approve the PR and add the reviewed tag and then I'll approve it and add the approve tag.
|
Hey @razvand, I missed the mail address. I have to correct that tomorrow morning. |
skuenzer
approved these changes
Feb 5, 2023
There was a problem hiding this comment.
Thanks a lot for this fix @mschlumpp
Reviewed-by: Simon Kuenzer simon@unikraft.io
Yes, please update 😉 |
The rxq interrupt flag was renamed in unikraft some time ago [1]. This adapts liblwip to this change. [1]: unikraft/unikraft@bf6ebd2 Signed-off-by: Marco Schlumpp <marco@unikraft.io>
mschlumpp
force-pushed
the
fix/force-polling-flag
branch
from
0c7a6fd
to
f97d65c
Compare
razvand
approved these changes
Feb 5, 2023
There was a problem hiding this comment.
Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rxq interrupt flag was renamed in unikraft some time ago 1. This adapts liblwip to this change.
Signed-off-by: Marco Schlumpp marco.schlumpp@gmail.com