Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SOCK_NONBLOCK to accept4 and socket() #33

Closed
wants to merge 1 commit into from
Closed

Add SOCK_NONBLOCK to accept4 and socket() #33

wants to merge 1 commit into from

Conversation

marcrittinghaus
Copy link
Member

@marcrittinghaus marcrittinghaus commented Apr 12, 2023 •
edited
Loading

This PR adds the SOCK_NONBLOCK flag to the accept4 and socket calls. It is part of the application compatibility push.

@marcrittinghaus marcrittinghaus self-assigned this Apr 19, 2023
@razvand razvand self-requested a review April 21, 2023 11:59
@razvand razvand added the enhancement New feature or request label Apr 21, 2023
@marcrittinghaus
Copy link
Member Author

This PR will receive some modification to include a fix for socket() (needed to resolve unikraft/unikraft#854) that will require changing the code that is introduced with this PR.

@marcrittinghaus
Add SOCK_NONBLOCK to accept4 and socket
6652005 
This commit adds support for the SOCK_NONBLOCK flag to
the accept4 and socket calls.

Signed-off-by: Marc Rittinghaus <marc.rittinghaus@unikraft.io>
@marcrittinghaus marcrittinghaus changed the title Add SOCK_NONBLOCK to accept4 Add SOCK_NONBLOCK to accept4 and socket() Apr 21, 2023
This was referenced Apr 21, 2023
Closed
Closed
razvand
razvand approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @marcrittinghaus. This works for me.

@mariasfiraiala , @eduardvintila , please see yourself.

When I have the OK from @eduardvintila , the assignee, I will then add my tag.

@eduardvintila
Copy link
Member

When I have the OK from @eduardvintila , the assignee, I will then add my tag.

All good on my side as well, @razvand. You can add the tag.

mariasfiraiala
mariasfiraiala approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@mariasfiraiala mariasfiraiala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good on my side @marcrittinghaus! I left a comment below, just out of curiosity. This PR looks alright so I'll leave the reviewed-by tag anyway.

Reviewed-by: Maria Sfiraiala maria.sfiraiala@gmail.com

sockets.c Show resolved Hide resolved
razvand
razvand approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Razvan Deaconescu razvand@unikraft.io

@razvand
Copy link
Contributor

razvand commented May 4, 2023

@eduardvintila, please approve this to have it merged.

@razvand razvand added this to the v0.13.0 (Atlas) milestone May 4, 2023
eduardvintila
eduardvintila approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@eduardvintila eduardvintila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Marc

Approved-by: Eduard Vintilă eduard.vintila47@gmail.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvand razvand razvand approved these changes

@eduardvintila eduardvintila eduardvintila approved these changes

@mariasfiraiala mariasfiraiala mariasfiraiala approved these changes

Assignees

@eduardvintila eduardvintila

Labels
ci/merged enhancement New feature or request
Projects
(Binary) Application Compatibility
Status: Done
Milestone
v0.13.0 (Atlas)
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marcrittinghaus @eduardvintila @razvand @mariasfiraiala @unikraft-bot