Adapt to new auxiliary stack argument of libuksched API
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 10, 2023
Merged
michpappas
approved these changes
Dec 18, 2023
|
@mogasergiu I just noticed there is a typo in the commit subject: "liuksched" |
Now all thread creation related functions also require an auxiliary stack-related argument: either a pointer to it or its desired length. Thus, provide argument 0 for length of auxiliary stack, allowing the allocation to use the default length. Signed-off-by: Sergiu Moga <sergiu@unikraft.io>
mogasergiu
force-pushed
the
smoga/auxsp_adapt
branch
from
6112b14
to
c14d8e7
Compare
mogasergiu
changed the title
liuksched APIlibuksched API
razvand
approved these changes
Dec 23, 2023
razvand
pushed a commit
that referenced
this pull request
Dec 23, 2023
Now all thread creation related functions also require an auxiliary stack-related argument: either a pointer to it or its desired length. Thus, provide argument 0 for length of auxiliary stack, allowing the allocation to use the default length. Signed-off-by: Sergiu Moga <sergiu@unikraft.io> Reviewed-by: Michalis Pappas <michalis@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now all thread creation related functions also require an auxiliary stack-related argument: either a pointer to it or its desired length.
Thus, provide argument 0 for length of auxiliary stack, allowing the allocation to use the default length.
Depends-on: #1174