Option to wait for DHCP and fail without netifs #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the option to fail booting if no network interface was found and can be used by lwip. Signed-off-by: Simon Kuenzer <simon@unikraft.io>
This commit introduces an configuration option to wait for the first network interface to be configured by DHCP. In case one interface is configured with a static IP, the sytem will immediately continue booting. Signed-off-by: Simon Kuenzer <simon@unikraft.io>
andreistan26
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Looks good to me, thanks!
Reviewed-by: Andrei Stan andreistan2003@gmail.com
razvand
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io
razvand
pushed a commit
that referenced
this pull request
Feb 9, 2024
This commit introduces the option to fail booting if no network interface was found and can be used by lwip. Signed-off-by: Simon Kuenzer <simon@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #47
razvand
pushed a commit
that referenced
this pull request
Feb 9, 2024
This commit introduces an configuration option to wait for the first network interface to be configured by DHCP. In case one interface is configured with a static IP, the sytem will immediately continue booting. Signed-off-by: Simon Kuenzer <simon@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two configuration options that let Unikraft to wait for DHCP responses and/or fail the boot without networking interface.