Set system hostname when initializing interface #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardvintila
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Looks good, thanks!
Reviewed-by: Eduard Vintilă eduard.vintila47@gmail.com
andreistan26
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Looks good to me, thanks!
Reviewed-by: Andrei Stan andreistan2003@gmail.com
skuenzer
reviewed
Feb 9, 2024
This change makes lwip set the system hostname to the one it receives during initialization, using the `sethostname` library call. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
andreittr
force-pushed
the
ttr/init-sethostname
branch
from
3d48ffc
to
695f710
Compare
skuenzer
approved these changes
Feb 9, 2024
skuenzer
pushed a commit
that referenced
this pull request
Feb 9, 2024
This change makes lwip set the system hostname to the one it receives during initialization, using the `sethostname` library call. Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Eduard Vintilă <eduard.vintila47@gmail.com> Approved-by: Simon Kuenzer <simon@unikraft.io> GitHub-Closes: #49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This change makes lwip set the system hostname to the one it receives during initialization, using the
sethostnamelibrary call.Depends on the following core Unikraft PR:
sethostnameunikraft#1307Testing
Syscalls such as
unameorgethostnameshould return the same hostname as passed to lwip through thenetdev.ipkernel parameter.