Skip to content

Commit

Permalink
Config.uk: Disable default LIBMUSL_COMPLEX
Browse files Browse the repository at this point in the history
When using Clang to build Musl with complex numbers support, a linking
error appears: `__muldc3` symbol is undefined. For Clang, the `__muldc3`
symbol is implemented by `libcompiler-rt`.

As complex number support is not typically required by applications
(that use Musl), this commit disable it by setting the `LIBMUSL_COMPLEX`
option to `n`. If required, the application will enable
`LIBMUSL_COMPLEX` (set it to `y`) and, in the case of Clang, add
`libcompiler-rt`.

Signed-off-by: Razvan Deaconescu <razvand@unikraft.io>
Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com>
Reviewed-by: Andrei Tatar <andrei@unikraft.io>
Approved-by: Maria Sfiraiala <maria.sfiraiala@gmail.com>
Tested-by: Unikraft CI <monkey@unikraft.io>
GitHub-Closes: #47
  • Loading branch information
razvand authored and unikraft-bot committed May 10, 2023
1 parent f7564c7 commit 45c4aa5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Config.uk
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ config LIBMUSL_AIO

config LIBMUSL_COMPLEX
bool "libcomplex"
default y
default n

config LIBMUSL_CONF
bool "libconf"
Expand Down

0 comments on commit 45c4aa5

Please sign in to comment.