Hide internal headers #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How to reproduce: Compile any app using lib-musl. Include Using after merging the PR, the preprocessor will not find |
kubanrob
force-pushed
the
hide-internal-headers
branch
from
7135495
to
1382a75
Compare
|
Update: Rebased onto latest state of thread_support (PR #9) |
michpappas
pushed a commit
to OpenSynergy/lib-musl
that referenced
this pull request
Aug 26, 2022
PR: unikraft#13 repository: https://github.com/kubanrob/lib-musl branch: hide-internal-headers fetched: Do 25. Aug 21:03:20 CEST 2022
mogasergiu
requested changes
Nov 9, 2022
kubanrob
force-pushed
the
hide-internal-headers
branch
from
1382a75
to
4bdda78
Compare
|
Update: Fixed typo (thanks @mogasergiu) and rebased on top of the current |
mogasergiu
approved these changes
Nov 11, 2022
Before, musl has exposed internal headers to other code, now the include paths are added to the appropriate variable. Signed-off-by: Robert Kuban <robert.kuban@opensynergy.com>
kubanrob
force-pushed
the
hide-internal-headers
branch
from
4bdda78
to
ce45c89
Compare
|
Update: rebased onto staging |
razvand
approved these changes
Nov 24, 2022
There was a problem hiding this comment.
Thanks, @kubanrob
Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch applies on top of #9, and includes two changes:
src/internal/version.hpreviously had a typo, leading to multiple definitions of VERSION.