Move _XOPEN_SOURCE define to library CFLAGS #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Putting it into CFLAGS changes the behavior for all sources files in a Unikraft build and changes them from the implicit _DEFAULT_SOURCE to _XOPEN_SOURCE, which can break applications/libraries. Signed-off-by: Marco Schlumpp <marco@unikraft.io>
StefanJum
approved these changes
Jan 27, 2023
There was a problem hiding this comment.
Looks good, depends on #32, since the old features.h file does not define _BSD_SOURCE and _XOPEN_SOURCE by default and trying to build without that commit will lead to undefined references to data types like timer_t, clockid_t, etc.
razvand
approved these changes
Jan 31, 2023
StefanJum
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting it into CFLAGS changes the behavior for all sources files in a Unikraft build and changes them from the implicit _DEFAULT_SOURCE to _XOPEN_SOURCE, which can break applications/libraries.