Makefile.uk: Add flag to avoid gcc specifc symbol #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanJum
reviewed
Mar 14, 2023
There was a problem hiding this comment.
Thanks @mariasfiraiala, it works on my side.
Since it feels a little tricky, would it make sense to add this only if libmath is selected in musl?
mariasfiraiala
force-pushed
the
fix-gcc-ism
branch
from
c0ebdd7
to
aa21294
Compare
|
@StefanJum I've amended the commit. Regarding adding the dependency on the |
StefanJum
suggested changes
Mar 20, 2023
When building apps with `clang` for `x86`, an asm specific symbol, `__muldc3`, appears, which results in a undefined reference error, at link time. This commit adds the `-ffast-math` flag, when `clang` is used in order to fix this issue. Signed-off-by: Maria Sfiraiala <maria.sfiraiala@gmail.com>
mariasfiraiala
force-pushed
the
fix-gcc-ism
branch
from
aa21294
to
1abd42c
Compare
StefanJum
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
All good now, thanks @mariasfiraiala.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
razvand
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building apps with
clangforx86, an asm specific symbol,__muldc3, which results in a undefined reference error, at link time.This PR adds the
-ffast-mathflag, whenclangis used in order to fix this issue.