Support for environment variables with lib/posix-environ
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 980bf21 enabled code for managing environment variables with musl, however they were never populated during boot. With PR ???, `posix-environ` envrionment variables are officially supported by Unikraft. This commit enables and integrates this implementation with musl. Signed-off-by: Simon Kuenzer <simon@unikraft.io>
We currently require `lib/uksched` to be enabled as part of the build. The dependency was not correctly stated with `Config.uk`. Signed-off-by: Simon Kuenzer <simon@unikraft.io>
razvand
requested review from
jobpaardekooper and
DeliaPavel
and removed request for
jobpaardekooper
DeliaPavel
approved these changes
May 6, 2023
There was a problem hiding this comment.
Looks good to me!
Reviewed-by: Delia Pavel delia_maria.pavel@stud.acs.upb.ro
razvand
approved these changes
May 7, 2023
unikraft-bot
pushed a commit
that referenced
this pull request
May 7, 2023
We currently require `lib/uksched` to be enabled as part of the build. The dependency was not correctly stated with `Config.uk`. Signed-off-by: Simon Kuenzer <simon@unikraft.io> Reviewed-by: Delia Pavel <delia_maria.pavel@stud.acs.upb.ro> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 980bf21 enabled code for managing environment variables with musl, however they were never populated during boot. With PR #868 in the Unikraft core environment variables are officially supported with
posix-environ. This PR enables and integrates this implementation with musl.