Makefile.uk: Fix gcc specific warnings #51
Conversation
There was a problem hiding this comment.
All good, thanks.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
There was a problem hiding this comment.
Thank you, @mbrdg! This PR gets rid of the warnings, great job! However, it would be great if you could update the commit description with a message such as:
-Wno-restrict,Wno-unused-but-set-variable,-Wno-maybe-unitializedand-Wno-format-contains-nulare gcc-specific flags, so include them only when compiling withgccand not withclang.
-Wno-restrict, Wno-unused-but-set-variable, -Wno-maybe-unitialized and -Wno-format-contains-nul are gcc-specific flags, so include them only when compiling with gcc and not with clang. Signed-off-by: Miguel Rodrigues <migb.rodrigues@gmail.com>
|
Just added the description in the commit! |
Thanks, @mbrdg. @eduardvintila , could you please see if it's OK with you, so we can approve it? |
There was a problem hiding this comment.
Great work, thanks a lot for this, @mbrdg!
Reviewed-by: Eduard Vintilă eduard.vintila47@gmail.com
Re-open after a force push to update the commit message.
Related to #50.
Signed-off-by: Miguel Rodrigues migb.rodrigues@gmail.com