Makefile.uk: Condition behavior on Kconfig #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanJum
suggested changes
Jul 1, 2023
There was a problem hiding this comment.
All good, thanks.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
There was a problem hiding this comment.
Hey, @andreittr. Good addition!
While we're at it, I think the aarch64_no_reserved_tcb_overlap rule should also include a similar check, so please add one there, as well. Thanks!
andreittr
changed the title
|
Update: rebased & added new commits |
razvand
reviewed
Jul 31, 2023
There was a problem hiding this comment.
This looks good to me. Tested and it works. @StefanJum, @eduardvintila, please add your review / approval, and then I'll add the final approval step.
StefanJum
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
All good.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
eduardvintila
approved these changes
Aug 6, 2023
There was a problem hiding this comment.
Thank you!
Reviewed-by: Eduard Vintilă eduard.vintila47@gmail.com
razvand
approved these changes
Aug 7, 2023
Previously musl's Makefile would unconditionally reserve a TCB size, regardless of whether musl was selected for build in Kconfig. This change makes this reservation happen only when musl is selected. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
Previously musl would unconditionally call `aarch64_no_reserved_tcb_overlap` when building under aarch64. This change makes this call happen only when musl is selected. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
Previously musl would add its headers to the include path unconditionally when its Makefile would be included. This change conditions this inclusion on whether musl is enabled via Kconfig. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
|
Rebased on staging. |
unikraft-bot
pushed a commit
that referenced
this pull request
Aug 10, 2023
Previously musl would unconditionally call `aarch64_no_reserved_tcb_overlap` when building under aarch64. This change makes this call happen only when musl is selected. Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Eduard Vintilă <eduard.vintila47@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #54
unikraft-bot
pushed a commit
that referenced
this pull request
Aug 10, 2023
Previously musl would add its headers to the include path unconditionally when its Makefile would be included. This change conditions this inclusion on whether musl is enabled via Kconfig. Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Eduard Vintilă <eduard.vintila47@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously musl's Makefile would unconditionally:
, regardless of whether musl was selected for build in Kconfig.
This change set makes these things happen only when musl is selected.
edit: updated w/ new commits