patches: Delete patching of ioctl call in isatty
#62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Application such as `python3` use `isatty()`, which does an `ioctl()` with `TIOCGWINSZ` as an argument for checking whether it should invoke the interactive interpretor or just start interpreting a given file. Therefore, we may want to allow such function call to return an error if called upon a file from a non-pseudo filesystem such as `ramfs` or `9pfs`. Furthermore, since this patch is the middle one among the existing patches from an order standpoint, rename the starting index of the other patches to reflect the removal. Signed-off-by: Sergiu Moga <sergiu@unikraft.io>
mogasergiu
force-pushed
the
smoga/delete-isatty-patch
branch
from
55806bf
to
e8890a3
Compare
RaduNichita
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
I tested with app-python3 and it builds and runs on both x86_64 and aarch64
Reviewed-by: Radu Nichita radunichita99@gmail.com
StefanJum
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Finally we can run a script using python3, thanks @mogasergiu 🚀 🚀
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
razvanvirtan
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
All good, thanks @mogasergiu !
Reviewed-by: Razvan Virtan virtanrazvan@gmail.com
skuenzer
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Application such as
python3useisatty(), which does anioctl()withTIOCGWINSZas an argument for checking whether it should invoke the interactive interpretor or just start interpreting a given file.Therefore, we may want to allow such function call to return an error if called upon a file from a non-pseudo filesystem such as
ramfsor9pfs.Furthermore, since this patch is the middle one among the existing patches from an order standpoint, rename the starting index of the other patches to reflect the removal.
This PR depends on
Unikraft Core RepositoryPR 981