Config.uk: Add uksignal dependency for LIBMUSL_SIGNAL
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`uksignal` should be selected automatically when `LIBMUSL_SIGNAL` is enabled, since it relies on underlying syscalls to be implemented by the kernel. Signed-off-by: Eduard Vintilă <eduard.vintila47@gmail.com>
eduardvintila
force-pushed
the
uksignal-dependency
branch
from
8da9490
to
bbd9348
Compare
StefanJum
approved these changes
Aug 5, 2023
There was a problem hiding this comment.
All good, thanks.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
RaduNichita
approved these changes
Aug 6, 2023
There was a problem hiding this comment.
All good. Thanks, @eduardvintila 💯
Reviewed-by: Radu Nichita radunichita99@gmail.com
razvand
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uksignalshould be selected automatically whenLIBMUSL_SIGNALis enabled, since it relies on underlying syscalls to be implemented by the kernel.Without it, we may run into issues such as this one, where
SIG_ERRORis returned when callingsignal()anduksignalis disabled.