Makefile.uk: Call tcb reserve conditionally #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ukarch_tls_tcb_reserve` call in `Makefile.uk` should only be made when Newlib is selected (i.e. when `CONFIG_LIBNEWLIBC` is set to `y`). Otherwise, if `newlib` is downloaded in the build directory, but is *not* selected in the configuration, a build error occurs: ``` LD simple_qemu-x86_64.dbg /usr/bin/ld: [...]/build/libcontext.o: in function `ukarch_tls_area_init': [...]/unikraft/arch/x86/x86_64/tls.c:201: undefined reference to `ukarch_tls_tcb_init' ``` Add an `ifeq` / `endif` wrapper to the call to `ukarch_tls_tcb_reserve`, such that the call is made only when Newlib is selected for configuration. Signed-off-by: Razvan Deaconescu <razvand@unikraft.io>
razvand
force-pushed
the
razvand/fix-tcb-reserve-conditional-call
branch
from
613a0e3
to
951c917
Compare
StefanJum
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
All good, thanks.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
eduardvintila
approved these changes
Aug 6, 2023
There was a problem hiding this comment.
Nice addition, thanks.
Approved-by: Eduard Vintilă eduard.vintila47@gmail.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ukarch_tls_tcb_reservecall inMakefile.ukshould only be made when Newlib is selected (i.e. whenCONFIG_LIBNEWLIBCis set toy). Otherwise, ifnewlibis downloaded in the build directory, but is not selected in the configuration, a build error occurs:Add an
ifeq/endifwrapper to the call toukarch_tls_tcb_reserve, such that the call is made only when Newlib is selected for configuration.