Add SHA256 checksum #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We add the SHA256 checksum of the downloaded archive so that Unikraft's build system is able to do an integrity check of the download. Signed-off-by: Simon Kuenzer <simon.kuenzer@neclab.eu>
razvand
approved these changes
Nov 29, 2021
There was a problem hiding this comment.
All OK.
Reviewed-by: Razvan Deaconescu razvan.deaconescu@cs.pub.ro
nderjung
approved these changes
Nov 29, 2021
unikraft-bot
pushed a commit
that referenced
this pull request
Nov 29, 2021
We add the SHA256 checksum of the downloaded archive so that Unikraft's build system is able to do an integrity check of the download. Signed-off-by: Simon Kuenzer <simon.kuenzer@neclab.eu> Reviewed-by: Razvan Deaconescu <razvan.deaconescu@cs.pub.ro> Approved-by: Alexander Jung <a.jung@lancs.ac.uk> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Pull-Request: #4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add the SHA256 checksum of the downloaded archive so that Unikraft's build system is able to do an integrity check of the download.
This commit can be applied even without integrating Unikraft PR 181 because it wouldn't have any effect in such a case.