include/pyconfig.h: Define SIZEOF_PHTREAD_T based on chosen libc
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The size of the `pthread_t` type varies between the libc/posix-threads implementations, so we need to define the `SIZEOF_PTHREAD_T` macro accordingly. This commit implements an additional check for the Pthread Embedded library. Signed-off-by: Eduard Vintilă <eduard.vintila47@gmail.com>
mariasfiraiala
approved these changes
Aug 5, 2023
There was a problem hiding this comment.
Makes sense, thanks for the addition @eduardvintila!
Reviewed-by: Maria Sfiraiala maria.sfiraiala@gmail.com
StefanJum
reviewed
Aug 6, 2023
There was a problem hiding this comment.
Thank you @eduardvintila. This will most likely conflict with #15, so I say we wait for that to be merged and then rebase, since this is a much smaller and easier to rebase pr.
StefanJum
approved these changes
Aug 11, 2023
razvand
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size of the
pthread_ttype varies between the libc/posix-threads implementations, so we need to define theSIZEOF_PTHREAD_Tmacro accordingly. This PR implements an additionalcheck for the Pthread Embedded library.
Signed-off-by: Eduard Vintilă eduard.vintila47@gmail.com