Makefile.uk: Allow configuring with custom config file #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craciunoiuc
reviewed
Jul 3, 2023
craciunoiuc
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
All good here. Thanks!
Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io
StefanJum
force-pushed
the
StefanJum/fix-custom-config
branch
from
97f612e
to
b8c0db0
Compare
The `.config.orig` rule does a backup of the config file before changing it to set `CONFIG_STACK_SIZE_PAGE_ORDER=10`. This used a hardcoded path to the default `.config` file instead of `$(C)`, which can be set to a custom one. Using a hardcoded path will fail if trying to build with a different config file than the default one (i.e. using `make C=path-to-config`). One of the usecases is `kraftkit`, which uses `.config.python3...` instead of the default `.config` file. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
StefanJum
force-pushed
the
StefanJum/fix-custom-config
branch
from
b8c0db0
to
f327619
Compare
razvand
approved these changes
Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.config.origrule does a backup of the config file before changing it to setCONFIG_STACK_SIZE_PAGE_ORDER=10. This used a hardcoded path to the default.configfile instead of$(C), which can be set to a custom one.