Add support for NumPy #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 25, 2023
StefanJum
requested changes
Aug 6, 2023
andreittr
force-pushed
the
ttr/py310-numpy
branch
2 times, most recently
from
e36e2ed
to
a4a1ad1
Compare
StefanJum
approved these changes
Aug 10, 2023
mariasfiraiala
approved these changes
Aug 11, 2023
There was a problem hiding this comment.
Works well, thanks!
Reviewed-by: Maria Sfiraiala maria.sfiraiala@gmail.com
|
@andreittr you can rebase this now, #15 is merged 🎉 |
This change only adds the necessary module registrations and Kconfig options. Numpy itself is provided by its own unikraft port. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
andreittr
force-pushed
the
ttr/py310-numpy
branch
from
a4a1ad1
to
fb4c0f2
Compare
StefanJum
approved these changes
Aug 11, 2023
There was a problem hiding this comment.
All good, thanks.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
razvand
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set adds support for the numpy extension in the main Python build.
Part of work on Python 3.10
and thus contains all its commits as well.
Only 5ad2760 is the actual numpy support. (Will rebase once Python PR is merged)
The NumPy microlibrary is a separate PR: