lang/rust: Change cargo flag #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkroening
reviewed
Jan 11, 2023
razvand
requested changes
Jan 13, 2023
Change the cargo flag from `-Z` to `-C` because the option `symbol-mangling-version` is stable in `rustc 1.68.0-nightly (388538fc9 2023-01-05)`. This removes a warning. Co-authored-by: Martin Kröning <mkroening@posteo.net> Signed-off-by: Fabian Patras <patras.fabi@gmail.com>
fabianpatras
force-pushed
the
rustc_version_upgrade
branch
from
c537676
to
9542954
Compare
razvand
approved these changes
Jan 13, 2023
There was a problem hiding this comment.
Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io
mkroening
approved these changes
Jan 13, 2023
There was a problem hiding this comment.
Looks good to me, but we should pin and enforce the Rust nightly version in the future. 👍
Reviewed-by: Martin Kröning mkroening@posteo.net
razvand
pushed a commit
that referenced
this pull request
Dec 30, 2023
Change the cargo flag from `-Z` to `-C` because the option `symbol-mangling-version` is stable in `rustc 1.68.0-nightly (388538fc9 2023-01-05)`. This removes a warning. Co-authored-by: Martin Kröning <mkroening@posteo.net> Signed-off-by: Fabian Patras <patras.fabi@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the cargo flag from
-Zto-Cbecausethe option
symbol-mangling-versionis stable inrustc 1.68.0-nightly (388538fc9 2023-01-05).This removes a warning.
Signed-off-by: Fabian Patras patras.fabi@gmail.com