Add c++ helloworld example application #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please use |
huyhoang8398
changed the title
razvand
requested changes
May 15, 2022
ouss-ch
suggested changes
Jun 26, 2022
razvand
requested changes
Jul 1, 2022
There was a problem hiding this comment.
Thanks, @huyhoang8398 . I made some comments.
Apart from those, please:
- Add the
helloworldexecutable file to the commit. - Remove the
Cfolder from the commit.
Add C++ helloworld application as static PIE: add source code, binary executable and Makefile. Signed-off-by: Do Hoang <huyhoang8398@gmail.com> Co-authored-by: Razvan Deaconescu <razvand@unikraft.io
razvand
approved these changes
Jan 3, 2023
There was a problem hiding this comment.
Thanks, @huyhoang8398.
Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add c++ helloworld example programs