plat/common: Add support for pvpanic devices for x86 #1022
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschlumpp
requested changes
Aug 7, 2023
craciunoiuc
force-pushed
the
craciunoiuc/add-pvpanic-support
branch
from
7b2f928
to
1a770ec
Compare
4 tasks
mschlumpp
requested changes
Aug 7, 2023
Unikraft already offers exit codes through the ISA device, but these are only a convention and are not understood by QEMU itself. When using `-device pvpanic`, a GUEST_PANICKED event[1] is sent to QEMU when the unikernel crashes. This event can be seen when using QMP[1] for example. The bits corresponding to each even are set as per the documentation[2]. The main usage of this is in kraftkit where unikernels are detached and exit codes are lost. Using this can signal when the unikernel crashes. [1] https://qemu-project.gitlab.io/qemu/interop/qemu-qmp-ref.html#qapidoc-152 [2] https://github.com/qemu/qemu/blob/master/docs/specs/pvpanic.txt Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@gmail.com>
craciunoiuc
force-pushed
the
craciunoiuc/add-pvpanic-support
branch
from
1a770ec
to
4d96b05
Compare
mschlumpp
approved these changes
Aug 7, 2023
razvand
approved these changes
Aug 7, 2023
unikraft-bot
added
area/plat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;Base target
x86_64kvmAdditional configuration
Use
-device pvpanicwhen testing withqemu-system-x86_64.Description of changes
Unikraft already offers exit codes through the ISA device, but these
are only a convention and are not understood by QEMU itself.
When using
-device pvpanic, a GUEST_PANICKED event[1] is sent to QEMUwhen the unikernel crashes.
This event can be seen when using QMP[1] for example.
The bits corresponding to each even are set as per the documentation[2].
The main usage of this is in kraftkit where unikernels are detached
and exit codes are lost.
Using this can signal when the unikernel crashes.
[1] https://qemu-project.gitlab.io/qemu/interop/qemu-qmp-ref.html#qapidoc-152
[2] https://github.com/qemu/qemu/blob/master/docs/specs/pvpanic.txt