Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/nolibc: Fix compiler warning for (f)scanf() prototypes #1029

Closed

Conversation

skuenzer
Copy link
Member

@skuenzer skuenzer commented Aug 8, 2023

This PR fixes a compiler warning about empty declarations introduced with commit e622c00 ("lib/nolibc: scanf and fscanf functions").

This commit fixes a compiler warning about empty declarations introduced
with commit e622c00 ("lib/nolibc: scanf and fscanf functions").

Signed-off-by: Simon Kuenzer <simon@unikraft.io>
@skuenzer skuenzer requested a review from a team as a code owner August 8, 2023 15:19
@unikraft-bot unikraft-bot added area/lib Internal Unikraft Microlibrary lib/nolibc Only neccessary subset of libc functionality labels Aug 8, 2023
@unikraft-bot
Copy link
Member

Checkpatch passed

Beep boop! I ran Unikraft's checkpatch.pl support script on your pull request and it all looks good!

SHA commit checkpatch
fa7a0f2 lib/nolibc: Fix compiler warning for `(f)scanf()` prototypes

@razvand razvand requested a review from StefanJum August 8, 2023 16:45
@razvand razvand self-assigned this Aug 8, 2023
@razvand razvand removed the request for review from dragosargint August 8, 2023 16:45
@razvand razvand added this to the v0.15.0 (Pandora) milestone Aug 8, 2023
@razvand razvand requested review from RaduNichita and removed request for a team August 8, 2023 16:46
@razvand razvand added kind/quick-fix Issue is a quick fix lang/c Issues or PRs to do with C/C++ labels Aug 8, 2023
Copy link
Contributor

@RaduNichita RaduNichita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, it solved the warning. Many thanks for the fix, @skuenzer

Sorry for introducing this warning, I would be more careful in the future.

Reviewed-by: Radu Nichita radunichita99@gmail.com

Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved-by: Razvan Deaconescu razvand@unikraft.io

@unikraft-bot unikraft-bot added the ci/merged Merged by CI label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/lib Internal Unikraft Microlibrary ci/merged Merged by CI kind/quick-fix Issue is a quick fix lang/c Issues or PRs to do with C/C++ lib/nolibc Only neccessary subset of libc functionality
Projects
Status: Done!
Development

Successfully merging this pull request may close these issues.

None yet

5 participants