Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github/workflows: Output all unikernel information and log test fails #1035

Closed
wants to merge 2 commits into from
Closed

.github/workflows: Output all unikernel information and log test fails #1035

wants to merge 2 commits into from

Conversation

craciunoiuc
Copy link
Member

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran the checkpatch.uk on your commit series before opening this PR;
  • Updated relevant documentation.

Base target

  • Architecture(s): [e.g. x86_64 or N/A]
  • Platform(s): [e.g. kvm, xen or N/A]
  • Application(s): [e.g. app-python3 or N/A]

Additional configuration

Description of changes

CONFIG_LIBUKDEBUG_PRINTK_INFO -- enables all unikernel output, including additional messages from uktest
CONFIG_LIBUKTEST_LOG_STATS -- enables test fails counting and printing at the end

@craciunoiuc
.github/workflows: Output all unikernel information
a4a203a 
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@gmail.com>
@craciunoiuc
.github/workflows: Enable test logging for libc-test
27c5946 
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@gmail.com>
@craciunoiuc craciunoiuc added kind/quick-fix Issue is a quick fix area/workflows Issue or PR relates to GitHub action workflows labels Aug 10, 2023
@craciunoiuc craciunoiuc requested a review from a team as a code owner August 10, 2023 15:32
@razvand razvand removed the request for review from a team August 10, 2023 15:35
@razvand razvand added this to the v0.14.0 (Prometheus) milestone Aug 10, 2023
razvand
razvand approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io

unikraft-bot pushed a commit that referenced this pull request Aug 10, 2023
@craciunoiuc @unikraft-bot
.github/workflows: Enable test logging for libc-test
cca4fc3 
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@gmail.com>
Reviewed-by: Razvan Deaconescu <razvand@unikraft.io>
Approved-by: Razvan Deaconescu <razvand@unikraft.io>
Tested-by: Unikraft CI <monkey@unikraft.io>
GitHub-Closes: #1035
@unikraft-bot unikraft-bot added the ci/merged Merged by CI label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvand razvand razvand approved these changes

@nderjung nderjung Awaiting requested review from nderjung

Assignees

@razvand razvand

Labels
area/workflows Issue or PR relates to GitHub action workflows ci/merged Merged by CI kind/quick-fix Issue is a quick fix
Projects
Unikraft Core Roadmap
Status: ✅ Done!
Milestone
v0.14.0 (Prometheus)
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@craciunoiuc @razvand @unikraft-bot