plat/common/x86: Fix libukreloc error for non-PIE SMP builds
#1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the merge of commit cf8cc65 ("plat/kvm/x86: Make SMP init code resolve its own `start16` relocations") SMP builds that were not built with `libukreloc` would fail due to external references to `x86_start16_*` symbols no longer being declared. Thus, fix this by making their declaration present regardless of `CONFIG_LIBUKRELOC` being enabled or not. Furthermore, guard the no longer necessary `START16_UKRELOC_*` macro's, as they are not needed if the previously mentioned configuration is not enabled. Signed-off-by: Sergiu Moga <sergiu@unikraft.io>
mschlumpp
approved these changes
Aug 11, 2023
razvand
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the merge of
commit cf8cc65 ("plat/kvm/x86: Make SMP init code resolve its own
start16relocations") SMP builds that were not built withlibukrelocwould fail due to external references tox86_start16_*symbols no longer being declared.Thus, fix this by making their declaration present regardless of
CONFIG_LIBUKRELOCbeing enabled or not. Furthermore, guard the no longer necessarySTART16_UKRELOC_*macro's, as they are not needed if the previously mentioned configuration is not enabled.Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;Base target
x86_64or N/A]kvm,xenor N/A]app-python3or N/A]Additional configuration
Description of changes