plat/kvm: Fix guest hang on UKPLAT_HALT during shutdown request

[mogasergiu]

As soon as
commit 170a8a4 ("plat/kvm/shutdown.c: If on a UEFI system, rely on Runtime Services") got merged guests would not finish on successful runs by exiting, but instead by halting.

Although confusing, the intention was to use UKPLAT_HALT for a graceful shutdown instead of a cpu_halt as it acts now.

Therefore, fix this by deleting the UKPLAT_HALT case from the switch statement.

Prerequisite checklist

• Read the contribution guidelines regarding submitting new changes to the project;
• Tested your changes against relevant architectures and platforms;
• Ran the checkpatch.uk on your commit series before opening this PR;
• Updated relevant documentation.

Base target

• Architecture(s): [e.g. x86_64 or N/A]
• Platform(s): [e.g. kvm, xen or N/A]
• Application(s): [e.g. app-python3 or N/A]

Additional configuration

Description of changes

[unikraft-bot]

⚠️ Checkpatch passed with warnings

Beep boop! I ran Unikraft's checkpatch.pl support script on your pull request but it encountered warnings:

SHA	commit	checkpatch
a8943d4	plat/kvm: Fix guest hang on `UKPLAT_HALT` during shutdown request	⚠️

Truncated logs starting from first warning a8943d4:

WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#8: 
commit 170a8a4fb242 ("plat/kvm/shutdown.c: If on a `UEFI` system, rely on Runtime Services")

total: 0 errors, 1 warnings, 10 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/tmp/build/a53d4c5b/patches/0001-plat-kvm-Fix-guest-hang-on-UKPLAT_HALT-during-shutdo.patch has style problems, please review.

NOTE: Ignored message types: ASSIGN_IN_IF FILE_PATH_CHANGES NEW_TYPEDEFS OBSOLETE

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

---

View complete logs | Learn more about Unikraft's coding style and contribution guidelines.

[nderjung]

This did the trick for me, thanks!

Reviewed-by: Alexander Jung alex@unikraft.io

[skuenzer]

Great, thanks!

Reviewed-by: Simon Kuenzer simon@unikraft.io
Approved-by: Simon Kuenzer simon@unikraft.io