support/qemu-guest: Workaround for TCG/x86 and Unikraft paging #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nderjung
reviewed
Aug 12, 2023
razvand
added
kind/quick-fix
StefanJum
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
All good, thanks.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
Limits QEMU PC machine model up to version 7.0 (pc-i440fx-7.0) for x86. This is primarily done to keep Unikraft compatibility with TCG. GitHub-Issue: unikraft#1040 Signed-off-by: Simon Kuenzer <simon@unikraft.io>
skuenzer
force-pushed
the
skuenzer/workaround-qemu-guest-tcg7.0
branch
from
9d43167
to
45e0cee
Compare
|
I pushed the updated. |
|
✅ Checkpatch passed Beep boop! I ran Unikraft's
|
razvand
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limits QEMU PC machine model up to version 7.0 (pc-i440fx-7.0) for x86. This is primarily done to keep Unikraft compatibility with TCG.
Related GitHub issue: #1040