plat/common: Align TLS sections to PAGE_SIZE #1050
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unikraft-bot
added
area/plat
razvand
requested review from
mschlumpp and
michpappas
and removed request for
a team and
vladandrew
mschlumpp
reviewed
Aug 15, 2023
`mkbootinfo.py` takes each ELF segment and aligns it to PAGE_SIZE to convert it to a `struct ukplat_memregion_desc`. However, this ends up generating overlapping memregion descriptors in the case of the ELF segment corresponding to the TLS sections. To solve this, simply ensure that the TLS sections are already aligned by PAGE_SIZE. Signed-off-by: Sergiu Moga <sergiu@unikraft.io>
mogasergiu
force-pushed
the
smoga/fix-tls-misaligned
branch
from
ede325e
to
db9814a
Compare
michpappas
approved these changes
Aug 15, 2023
|
✅ Checkpatch passed Beep boop! I ran Unikraft's
|
mschlumpp
approved these changes
Aug 15, 2023
razvand
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mkbootinfo.pytakes each ELF segment and aligns it to PAGE_SIZE to convert it to astruct ukplat_memregion_desc. However, this ends up generating overlapping memregion descriptors in the case of the ELF segment corresponding to the TLS sections.To solve this, simply ensure that the TLS sections are already aligned by PAGE_SIZE.
Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;Base target
x86_64or N/A]kvm,xenor N/A]app-python3or N/A]Additional configuration
Description of changes