plat/kvm: Check return code of all memory region inserting methods #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unikraft-bot
added
area/plat
razvand
requested review from
mschlumpp and
michpappas
and removed request for
vladandrew
mogasergiu
force-pushed
the
smoga/check_rc_memregion
branch
2 times, most recently
from
f84dfa3
to
9f84e66
Compare
mogasergiu
force-pushed
the
smoga/check_rc_memregion
branch
from
9f84e66
to
7eac436
Compare
mschlumpp
approved these changes
Aug 15, 2023
|
@michpappas Do not merge this until the prerequisite PR is in! |
michpappas
approved these changes
Aug 15, 2023
That would be @razvand :) |
Make sure that we do check the return codes of all of the memory region inserting methods so that we can crash in case of failure, instead of letting the system run with a corrupted state. Signed-off-by: Sergiu Moga <sergiu@unikraft.io>
mogasergiu
force-pushed
the
smoga/check_rc_memregion
branch
from
7eac436
to
4698612
Compare
razvand
approved these changes
Aug 15, 2023
|
✅ Checkpatch passed Beep boop! I ran Unikraft's
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that we do check the return codes of all of the memory region inserting methods so that we can crash in case of failure, instead of letting the system run with a corrupted state.
Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;Base target
x86_64or N/A]kvm,xenor N/A]app-python3or N/A]Additional configuration
Description of changes