plat/kvm/arm: Fix default choice in arm64 VMM menu #1053
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the default selection of the VMM in Config.uk. Kconfig requires that the default is defined as an attribute of the `choice` option rather than the contained item. Signed-off-by: Michalis Pappas <michalis@unikraft.io>
|
✅ Checkpatch passed Beep boop! I ran Unikraft's
|
razvand
requested review from
StefanJum and
mariasfiraiala
and removed request for
a team and
dragosargint
razvand
added
area/kconfig
StefanJum
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
All good, thanks.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
mariasfiraiala
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Everything ok on my side as well.
Reviewed-by: Maria Sfiraiala maria.sfiraiala@gmail.com
razvand
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;Base target
arm64]kvm]Additional configuration
Description of changes
Fix the default selection of the VMM in Config.uk. Kconfig requires that the default is defined as an attribute of the
choiceoption rather than the contained item.