lib/posix-environ: Remove unused variable warnings #1058
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an environment variable is not set, the `DECLARE_LIBPOSIX_ENVIRON_ENV_VAR` macros end up declaring unused global variables which generate warnings. To solve this, guard the use of these macros so that they are not used for a particular unset environment variable. Signed-off-by: Sergiu Moga <sergiu@unikraft.io>
razvand
added
topic/posix
|
✅ Checkpatch passed Beep boop! I ran Unikraft's
|
michpappas
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
An alternative would had been to use __maybe_unused in the declaration macro. I guess it doesn't matter too much though as these are wrapped around conditionally below a few times already.
Reviewed-by: Michalis Pappas michalis@unikraft.io
skuenzer
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;Base target
Additional configuration
Description of changes
If an environment variable is not set, the
DECLARE_LIBPOSIX_ENVIRON_ENV_VARmacros end up declaring unused global variables which generate warnings.To solve this, guard the use of these macros so that they are not used for a particular unset environment variable.