Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github/workflows: Add github workflows checks #1137

Merged
merged 1 commit into from Dec 30, 2023
Merged

.github/workflows: Add github workflows checks #1137

merged 1 commit into from Dec 30, 2023

Conversation

craciunoiuc
Copy link
Member

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran the checkpatch.uk on your commit series before opening this PR;
  • Updated relevant documentation.

Base target

  • Architecture(s): [e.g. x86_64 or N/A]
  • Platform(s): [e.g. kvm, xen or N/A]
  • Application(s): [e.g. app-python3 or N/A]

Additional configuration

Description of changes

@craciunoiuc craciunoiuc requested a review from a team as a code owner October 14, 2023 09:22
@razvand razvand removed the request for review from a team October 14, 2023 09:33
@razvand razvand added the area/workflows Issue or PR relates to GitHub action workflows label Oct 14, 2023
@razvand razvand added this to the v0.15.0 (Pandora) milestone Oct 14, 2023
@razvand razvand requested review from a team as code owners October 20, 2023 16:36
@craciunoiuc
.github/workflows: Add github workflows checks
2090a0d 
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@gmail.com>
@craciunoiuc craciunoiuc force-pushed the craciunoiuc/add-workflow-linting branch from cfa4836 to 2090a0d Compare November 2, 2023 15:29
@craciunoiuc craciunoiuc removed request for a team December 17, 2023 11:45
@craciunoiuc craciunoiuc removed request for a team December 17, 2023 11:45
razvand
razvand approved these changes Dec 30, 2023
View reviewed changes
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io

@razvand razvand assigned razvand and unassigned nderjung Dec 30, 2023
@razvand razvand changed the base branch from staging to staging-1137 December 30, 2023 03:35
@razvand razvand merged commit 62d87fa into unikraft:staging-1137 Dec 30, 2023
10 checks passed
razvand pushed a commit that referenced this pull request Dec 30, 2023
@craciunoiuc @razvand
.github/workflows: Add github workflows checks
9f9475f 
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@gmail.com>
Approved-by: Razvan Deaconescu <razvand@unikraft.io>
Reviewed-by: Razvan Deaconescu <razvand@unikraft.io>
GitHub-Closes: #1137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvand razvand razvand approved these changes

@mschlumpp mschlumpp Awaiting requested review from mschlumpp

@skuenzer skuenzer Awaiting requested review from skuenzer

Assignees

@razvand razvand

Labels
area/workflows Issue or PR relates to GitHub action workflows
Projects
Unikraft Core Roadmap
Status: ✅ Done!
Milestone
v0.17.0 (Calypso)
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@craciunoiuc @razvand @nderjung @razvanvirtan