plat/xen/x86_64: Add missing segment alignment for xen
#1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreistan26
changed the title
xen on x86_84xen
|
错误报告 阻止 |
mogasergiu
requested changes
Dec 9, 2023
There was a problem hiding this comment.
Hi, thanks for looking into this! Looks good! Just a couple of things 🤓:
- s/alignement/alignment/
- s/This fixes a memory overlap/This fixes a memory region overlap
- no "Merge" commits! You probably got this from an attempt to rebase 😃. In the future you can simply
git remote update; git pull origin staging --rebase. Now you will have to force push the branch your PR is based on ☝️ .
andreistan26
force-pushed
the
misaligned-section-xen
branch
from
b53e211
to
ecc0682
Compare
Make the second segment in a `xen/x86-64` ELF aligned to the page size. This fixes a memory region overlap issue that triggers an assert during memory coalescing. Signed-off-by: Andrei Stan <andreistan2003@gmail.com>
andreistan26
force-pushed
the
misaligned-section-xen
branch
from
ecc0682
to
165b024
Compare
andreistan26
changed the title
xenxen
mogasergiu
approved these changes
Dec 17, 2023
There was a problem hiding this comment.
Thanks for your work.
Reviewed-by: Sergiu Moga sergiu@unikraft.io
Approved-by: Sergiu Moga sergiu@unikraft.io
razvand
approved these changes
Dec 23, 2023
razvand
pushed a commit
that referenced
this pull request
Dec 23, 2023
Make the second segment in a `xen/x86-64` ELF aligned to the page size. This fixes a memory region overlap issue that triggers an assert during memory coalescing. Signed-off-by: Andrei Stan <andreistan2003@gmail.com> Approved-by: Sergiu Moga <sergiu@unikraft.io> Reviewed-by: Sergiu Moga <sergiu@unikraft.io> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #1166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;Base target
x86_64xenAdditional configuration
Description of changes
Make the second segment in a
xen/x86-64ELF aligned to the page size.This fixes a memory overlap issue that triggers an assert during
memory coalescing.