Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stefan jum/posiz sysinfo #1178

Merged
merged 2 commits into from Dec 30, 2023

Conversation

StefanJum
Copy link
Member

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran the checkpatch.uk on your commit series before opening this PR;
  • Updated relevant documentation.

Description of changes

Add a README file and comments to header files for the posix-sysinfo library.

Add a minimal README that includes basic information abot the library,
as well as a simple application example.

Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
@StefanJum StefanJum added kind/enhancement New feature or request area/docs Documentation lib/posix-sysinfo labels Nov 27, 2023
@StefanJum StefanJum requested a review from a team as a code owner November 27, 2023 14:22
@StefanJum StefanJum removed the request for review from a team November 27, 2023 14:22
@razvand razvand added this to the v0.16.0 (Telesto) milestone Dec 6, 2023
Copy link
Contributor

@RaduNichita RaduNichita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @StefanJum! 💯

Please have a look at my comments

lib/posix-sysinfo/README.md Outdated Show resolved Hide resolved
lib/posix-sysinfo/README.md Outdated Show resolved Hide resolved
lib/posix-sysinfo/include/sys/sysinfo.h Show resolved Hide resolved
lib/posix-sysinfo/sysinfo.c Outdated Show resolved Hide resolved
lib/posix-sysinfo/README.md Outdated Show resolved Hide resolved
lib/posix-sysinfo/README.md Outdated Show resolved Hide resolved
Add doxygen-style code comments to the `posix-sysinfo` internal library
files.

Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io

@razvand razvand changed the base branch from staging to staging-1178 December 30, 2023 18:42
@razvand razvand merged commit ee91456 into unikraft:staging-1178 Dec 30, 2023
10 of 12 checks passed
razvand pushed a commit that referenced this pull request Dec 30, 2023
Add a minimal README that includes basic information abot the library,
as well as a simple application example.

Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
Approved-by: Razvan Deaconescu <razvand@unikraft.io>
Reviewed-by: Razvan Deaconescu <razvand@unikraft.io>
GitHub-Closes: #1178
razvand pushed a commit that referenced this pull request Dec 30, 2023
Add doxygen-style code comments to the `posix-sysinfo` internal library
files.

Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
Approved-by: Razvan Deaconescu <razvand@unikraft.io>
Reviewed-by: Razvan Deaconescu <razvand@unikraft.io>
GitHub-Closes: #1178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation kind/enhancement New feature or request lib/posix-sysinfo
Projects
Status: Done!
Development

Successfully merging this pull request may close these issues.

None yet

3 participants