New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stefan jum/posiz sysinfo #1178
Stefan jum/posiz sysinfo #1178
Conversation
Add a minimal README that includes basic information abot the library, as well as a simple application example. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @StefanJum! 💯
Please have a look at my comments
Add doxygen-style code comments to the `posix-sysinfo` internal library files. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
70945a4
to
fd704c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io
Add a minimal README that includes basic information abot the library, as well as a simple application example. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #1178
Add doxygen-style code comments to the `posix-sysinfo` internal library files. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> Reviewed-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #1178
Prerequisite checklist
checkpatch.uk
on your commit series before opening this PR;Description of changes
Add a README file and comments to header files for the
posix-sysinfo
library.