Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/posix-environ: Add comments for posix-environ #1184

Merged
merged 1 commit into from Dec 30, 2023
Merged

lib/posix-environ: Add comments for posix-environ #1184

merged 1 commit into from Dec 30, 2023

Conversation

DeliaPavel
Copy link
Contributor

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran the checkpatch.uk on your commit series before opening this PR;
  • Updated relevant documentation.

Base target

  • Architecture(s): [e.g. x86_64 or N/A]
  • Platform(s): [e.g. kvm, xen or N/A]
  • Application(s): [e.g. app-python3 or N/A]

Additional configuration

Description of changes

@DeliaPavel DeliaPavel requested a review from a team as a code owner December 2, 2023 16:31
@razvand razvand removed the request for review from a team December 6, 2023 11:07
@razvand razvand added this to the v0.16.0 (Telesto) milestone Dec 6, 2023
StefanJum
StefanJum requested changes Dec 23, 2023
View reviewed changes
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment @DeliaPavel, all good after that.

lib/posix-environ/environ.h Outdated Show resolved Hide resolved
@DeliaPavel
lib/posix-environ: Add comments for posix-environ
5d36ae6 
Signed-off-by: Delia-Maria Pavel <delia_maria.pavel@stud.acs.upb.ro>
StefanJum
StefanJum approved these changes Dec 23, 2023
View reviewed changes
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @DeliaPavel
Approved-by: Stefan Jumarea stefanjumarea02@gmail.com

razvand
razvand approved these changes Dec 30, 2023
View reviewed changes
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Razvan Deaconescu razvand@unikraft.io

@razvand razvand changed the base branch from staging to staging-1184 December 30, 2023 04:33
@razvand razvand merged commit 1d6272a into unikraft:staging-1184 Dec 30, 2023
10 checks passed
razvand pushed a commit that referenced this pull request Dec 30, 2023
@DeliaPavel @razvand
lib/posix-environ: Add comments for posix-environ
9e5add4 
Signed-off-by: Delia-Maria Pavel <delia_maria.pavel@stud.acs.upb.ro>
Approved-by: Stefan Jumarea <stefanjumarea02@gmail.com>
Reviewed-by: Razvan Deaconescu <razvand@unikraft.io>
GitHub-Closes: #1184
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvand razvand razvand approved these changes

@StefanJum StefanJum StefanJum approved these changes

Assignees

@StefanJum StefanJum

Labels
None yet
Projects
Unikraft Core Roadmap
Status: ✅ Done!
Milestone
v0.16.0 (Telesto)
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DeliaPavel @razvand @StefanJum