Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github/workflows: Add workflow to merge approved PRs #1209

Merged
merged 2 commits into from Dec 20, 2023
Merged

.github/workflows: Add workflow to merge approved PRs #1209

merged 2 commits into from Dec 20, 2023

Conversation

craciunoiuc
Copy link
Member

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran the checkpatch.uk on your commit series before opening this PR;
  • Updated relevant documentation.

Base target

  • Architecture(s): [e.g. x86_64 or N/A]
  • Platform(s): [e.g. kvm, xen or N/A]
  • Application(s): [e.g. app-python3 or N/A]

Additional configuration

Description of changes

Do not merge this yet as governctl was not updated yet.

@craciunoiuc craciunoiuc requested a review from a team as a code owner December 15, 2023 13:33
@razvand razvand requested review from razvand and removed request for a team December 15, 2023 21:13
@razvand razvand added the topic/build Topics to do with the build system label Dec 15, 2023
@razvand razvand added this to the v0.16.0 (Telesto) milestone Dec 15, 2023
@razvand
Copy link
Contributor

razvand commented Dec 15, 2023 •
edited

@craciunoiuc , there was a force push that "added" two extra commits to your PR. Please rebase it.

@craciunoiuc
.github/workflows: Add workflow to merge approved PRs
13feac1 
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@gmail.com>
@craciunoiuc craciunoiuc force-pushed the craciunoiuc/workflow-for-auto-merge branch from 37b0489 to 13feac1 Compare December 17, 2023 13:10
@craciunoiuc craciunoiuc changed the base branch from staging to testbr December 19, 2023 17:02
skuenzer
skuenzer approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@skuenzer skuenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Simon Kuenzer simon@unikraft.io

@craciunoiuc craciunoiuc force-pushed the craciunoiuc/workflow-for-auto-merge branch from da678a0 to 3037e63 Compare December 20, 2023 09:30
skuenzer
skuenzer approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@skuenzer skuenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Simon Kuenzer simon@unikraft.io

@craciunoiuc craciunoiuc force-pushed the craciunoiuc/workflow-for-auto-merge branch from 3037e63 to 8947821 Compare December 20, 2023 09:42
skuenzer
skuenzer approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@skuenzer skuenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Simon Kuenzer simon@unikraft.io

@craciunoiuc craciunoiuc force-pushed the craciunoiuc/workflow-for-auto-merge branch from 8947821 to b086b36 Compare December 20, 2023 10:42
skuenzer
skuenzer approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@skuenzer skuenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Simon Kuenzer simon@unikraft.io

@craciunoiuc craciunoiuc force-pushed the craciunoiuc/workflow-for-auto-merge branch from b086b36 to 104e639 Compare December 20, 2023 10:50
skuenzer
skuenzer approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@skuenzer skuenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved-by: Simon Kuenzer simon@unikraft.io

@craciunoiuc
.github/workflows: Use test branch for initial checks
add366b 
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@gmail.com>
@craciunoiuc craciunoiuc force-pushed the craciunoiuc/workflow-for-auto-merge branch from 104e639 to add366b Compare December 20, 2023 11:07
skuenzer
skuenzer approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@skuenzer skuenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved-by: Simon Kuenzer simon@unikraft.io

skuenzer
skuenzer approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@skuenzer skuenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved-by: Simon Kuenzer simon@unikraft.io

@unikraft-bot unikraft-bot changed the base branch from testbr to testbr-1209 December 20, 2023 11:30
@unikraft-bot unikraft-bot merged commit 165de93 into unikraft:testbr-1209 Dec 20, 2023
2 of 3 checks passed
unikraft-bot pushed a commit that referenced this pull request Dec 20, 2023
@craciunoiuc
.github/workflows: Add workflow to merge approved PRs
e34960d 
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@gmail.com>
Reviewed-by: Simon Kuenzer <simon@unikraft.io>
Approved-by: Simon Kuenzer <simon@unikraft.io>
GitHub-Closes: #1209
unikraft-bot pushed a commit that referenced this pull request Dec 20, 2023
@craciunoiuc
.github/workflows: Use test branch for initial checks
15542d2 
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@gmail.com>
Reviewed-by: Simon Kuenzer <simon@unikraft.io>
Approved-by: Simon Kuenzer <simon@unikraft.io>
GitHub-Closes: #1209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skuenzer skuenzer skuenzer approved these changes

@razvand razvand Awaiting requested review from razvand

Assignees

@skuenzer skuenzer

Labels
topic/build Topics to do with the build system
Projects
Unikraft Core Roadmap
Status: ✅ Done!
Milestone
v0.16.0 (Telesto)
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@craciunoiuc @razvand @skuenzer @unikraft-bot