Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/posix-fdtab: Add comments for posix-fdtab #1241

Merged
merged 1 commit into from
Feb 6, 2024
Merged

lib/posix-fdtab: Add comments for posix-fdtab #1241

merged 1 commit into from
Feb 6, 2024

Conversation

DeliaPavel
Copy link
Contributor

Signed-off-by: Delia-Maria Pavel delia_maria.pavel@stud.acs.upb.ro

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran the checkpatch.uk on your commit series before opening this PR;
  • Updated relevant documentation.

Base target

  • Architecture(s): [e.g. x86_64 or N/A]
  • Platform(s): [e.g. kvm, xen or N/A]
  • Application(s): [e.g. app-python3 or N/A]

Additional configuration

Description of changes

@DeliaPavel
lib/posix-fdtab: Add comments for posix-fdtab
9b50611 
Signed-off-by: Delia-Maria Pavel <delia_maria.pavel@stud.acs.upb.ro>
@DeliaPavel DeliaPavel requested a review from a team as a code owner January 7, 2024 20:24
@razvand razvand removed the request for review from a team January 10, 2024 07:40
@razvand razvand self-assigned this Jan 10, 2024
@razvand razvand added area/lib Internal Unikraft Microlibrary area/docs Documentation lib/posix-fdtab Library to hande file descriptor table with a POSIX-compatible interface labels Jan 10, 2024
@razvand razvand added this to the v0.17.0 (Calypso) milestone Jan 10, 2024
@razvand razvand modified the milestones: v0.17.0 (Calypso), v0.16.2 Feb 1, 2024
@razvand razvand requested review from RaduNichita and removed request for razvand February 6, 2024 17:20
StefanJum
StefanJum approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks @DeliaPavel
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com

razvand
razvand approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved-by: Razvan Deaconescu razvand@unikraft.io

@razvand razvand added the merge Label to trigger merge action label Feb 6, 2024
@unikraft-bot unikraft-bot changed the base branch from staging to staging-1241 February 6, 2024 21:48
@unikraft-bot unikraft-bot merged commit 2d782ce into unikraft:staging-1241 Feb 6, 2024
16 checks passed
unikraft-bot pushed a commit that referenced this pull request Feb 6, 2024
@DeliaPavel @unikraft-bot
lib/posix-fdtab: Add comments for posix-fdtab
fad8de3 
Signed-off-by: Delia-Maria Pavel <delia_maria.pavel@stud.acs.upb.ro>
Approved-by: Razvan Deaconescu <razvand@unikraft.io>
Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com>
GitHub-Closes: #1241
@unikraft-bot unikraft-bot added ci/merged Merged by CI and removed merge Label to trigger merge action labels Feb 6, 2024
SerbanSo pushed a commit to SerbanSo/unikraft-ASLR that referenced this pull request Jun 16, 2024
@DeliaPavel @SerbanSo
lib/posix-fdtab: Add comments for posix-fdtab
e6764dc 
Signed-off-by: Delia-Maria Pavel <delia_maria.pavel@stud.acs.upb.ro>
Approved-by: Razvan Deaconescu <razvand@unikraft.io>
Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com>
GitHub-Closes: unikraft#1241
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvand razvand razvand approved these changes

@StefanJum StefanJum StefanJum approved these changes

@RaduNichita RaduNichita Awaiting requested review from RaduNichita

Assignees

@razvand razvand

Labels
area/docs Documentation area/lib Internal Unikraft Microlibrary ci/merged Merged by CI lib/posix-fdtab Library to hande file descriptor table with a POSIX-compatible interface
Projects
Unikraft Core Roadmap
Status: ✅ Done!
Milestone
v0.16.2 (Telesto)
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DeliaPavel @razvand @StefanJum @unikraft-bot