lib/posix-socket: Extend socket events #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcrittinghaus
added
kind/enhancement
github-actions
bot
added
area/lib
skuenzer
reviewed
Jan 25, 2024
This commit extends the socket events so that each socket keeps track of its current state. This allows event handlers to determine when a socket function is called multiple times in a row (e.g., nginx calls listen twice) and, for what type of socket a close is performed (e.g., listen socket). As part of this extension, the single socket event is split up into dedicated event objects per event. This avoids calling the hook for events that are not of interest. Signed-off-by: Marc Rittinghaus <marc.rittinghaus@unikraft.io>
marcrittinghaus
force-pushed
the
mritting/pr_socket_events
branch
from
280f139
to
8f635ad
Compare
skuenzer
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Great, works now as we discussed. Thanks a lot!
Reviewed-by: Simon Kuenzer simon@unikraft.io
Approved-by: Simon Kuenzer simon@unikraft.io
razvand
pushed a commit
that referenced
this pull request
Jan 26, 2024
This commit extends the socket events so that each socket keeps track of its current state. This allows event handlers to determine when a socket function is called multiple times in a row (e.g., nginx calls listen twice) and, for what type of socket a close is performed (e.g., listen socket). As part of this extension, the single socket event is split up into dedicated event objects per event. This avoids calling the hook for events that are not of interest. Signed-off-by: Marc Rittinghaus <marc.rittinghaus@unikraft.io> Reviewed-by: Simon Kuenzer <simon@unikraft.io> Approved-by: Simon Kuenzer <simon@unikraft.io> GitHub-Closes: #1279
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;Base target
Additional configuration
CONFIG_LIBPOSIX_SOCKET_EVENTSDescription of changes
This commit extends the socket events so that each socket keeps track of its current state. This allows event handlers to determine when a socket function is called multiple times in a row (e.g., nginx calls listen twice) and, for what type of socket a close is performed (e.g., listen socket).
As part of this extension, the single socket event is split up into dedicated event objects per event. This avoids calling the hook for events that are not of interest.