lib/posix-fdio: ENOTTY for unsupported tty ioctls #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes ioctl universally return -ENOTTY for tty-specific ioctls that are not supported by the file driver, which it in turn signals by returning -ENOSYS. Checkpatch-Ignore: ENOSYS Signed-off-by: Andrei Tatar <andrei@unikraft.io>
github-actions
bot
added
area/lib
razvand
requested review from
mogasergiu and
StefanJum
and removed request for
a team
mogasergiu
reviewed
Feb 3, 2024
mogasergiu
approved these changes
Feb 5, 2024
StefanJum
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
All good, thanks.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
razvand
approved these changes
Feb 6, 2024
unikraft-bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
This change makes ioctl universally return -ENOTTY for tty-specific ioctls that are not supported by the file driver, which it in turn signals by returning -ENOSYS. Checkpatch-Ignore: ENOSYS Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Sergiu Moga <sergiu@unikraft.io> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #1301
unikraft-bot
added
ci/merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This change makes ioctl universally return -ENOTTY for tty-specific ioctls that are not supported by the file driver, which it in turn signals by returning -ENOSYS.
Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;Base target
Additional configuration
N/A