lib/vfscore: Prevent superfluous slashes in working directory #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/lib
razvand
requested review from
RaduNichita and
StefanJum
and removed request for
a team
RaduNichita
suggested changes
Feb 2, 2024
The mount point can contain a trailing slash (for example the root mount point has a path of "/"). The path that is concatenated to the mount point also contains a slash at the beginning. Therefore, extra care must be taken to prevent two slashes from appearing besides each other. Signed-off-by: Marco Schlumpp <marco@unikraft.io>
mschlumpp
force-pushed
the
mschlumpp/fix/chdir-path
branch
from
838fe88
to
a2c01e2
Compare
StefanJum
approved these changes
Feb 5, 2024
RaduNichita
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Looks good.
Reviewed-by: Radu Nichita radunichita99@gmail.com
razvand
approved these changes
Feb 6, 2024
unikraft-bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
The mount point can contain a trailing slash (for example the root mount point has a path of "/"). The path that is concatenated to the mount point also contains a slash at the beginning. Therefore, extra care must be taken to prevent two slashes from appearing besides each other. Signed-off-by: Marco Schlumpp <marco@unikraft.io> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Reviewed-by: Radu Nichita <radunichita99@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #1302
unikraft-bot
added
ci/merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mount point can contain a trailing slash (for example the root mount point has a path of "/"). The path that is concatenated to the mount point also contains a slash at the beginning. Therefore, extra care must be taken to prevent two slashes from appearing besides each other.
Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;Base target
Additional configuration
Description of changes