lib/posix-process: Add option to context switch away from clone caller #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/lib
|
Note: it is undecided whether we want to prioritize the parent or the children by default. (cc @michpappas) |
razvand
requested review from
eduardvintila and
Mihnea0Firoiu
and removed request for
a team
eduardvintila
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Nice addition, looks good to me.
Reviewed-by: Eduard Vintilă eduard.vintila47@gmail.com
Mihnea0Firoiu
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Looks good to me.
Reviewed-by: Mihnea Firoiu mihneafiroiu0@gmail.com
michpappas
requested changes
Feb 7, 2024
There was a problem hiding this comment.
@mschlumpp just one minor comment below. Regarding ordering: As discussed offline, there isn't a good default in our case so let's leave it as is.
mschlumpp
force-pushed
the
mschlumpp/feature/clone-deschedule
branch
from
aa15b4c
to
a92bfff
Compare
mschlumpp
force-pushed
the
mschlumpp/feature/clone-deschedule
branch
from
a92bfff
to
4def7c7
Compare
Some applications are expecting to run on a cooperative scheduler and will naively assume that the new thread will do some progress even if the clone caller does not context-switch by blocking/yielding. Signed-off-by: Marco Schlumpp <marco@unikraft.io>
mschlumpp
force-pushed
the
mschlumpp/feature/clone-deschedule
branch
from
4def7c7
to
23683db
Compare
|
Approved-by: Michalis Pappas michalis@unikraft.io |
unikraft-bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
Some applications are expecting to run on a cooperative scheduler and will naively assume that the new thread will do some progress even if the clone caller does not context-switch by blocking/yielding. Signed-off-by: Marco Schlumpp <marco@unikraft.io> Approved-by: Michalis Pappas <michalis@unikraft.io> Reviewed-by: Eduard Vintilă <eduard.vintila47@gmail.com> Reviewed-by: Mihnea Firoiu <mihneafiroiu0@gmail.com> GitHub-Closes: #1303
unikraft-bot
added
ci/merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some applications are expecting to run on a cooperative scheduler and will naively assume that the new thread will do some progress even if the clone caller does not context-switch by blocking/yielding.
Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;Base target
Additional configuration
CONFIG_LIBPOSIX_PROCESS_CLONE_PREFER_CHILD=yDescription of changes