lib/posix-socket: Expose internal socket syscalls #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/lib
razvand
requested review from
RaduNichita,
StefanJum and
Mihnea0Firoiu
and removed request for
a team
Mihnea0Firoiu
approved these changes
May 11, 2024
There was a problem hiding this comment.
All good!
Reviewed-by: Mihnea Firoiu mihneafiroiu0@gmail.com
RaduNichita
approved these changes
May 13, 2024
There was a problem hiding this comment.
Thanks @andreittr, it looks good.
Reviewed-by: Radu Nichita radunichita99@gmail.com
StefanJum
requested changes
May 15, 2024
There was a problem hiding this comment.
@andreittr should we also add the exposed symbols in exportsyms.uk?
andreittr
force-pushed
the
ttr/socket-intapi
branch
from
b7df93b
to
c156096
Compare
Good catch @StefanJum, thanks! Added & rebased to current staging. |
StefanJum
approved these changes
May 24, 2024
This change exposes Unikraft-internal syscalls that create sockets. Both versions returning raw uk_files as well as opened file descriptors are provided. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
andreittr
force-pushed
the
ttr/socket-intapi
branch
from
c156096
to
3246b05
Compare
|
Force-push: rebased on current staging & patched to work with changes introduced in a922af7. |
razvand
approved these changes
May 29, 2024
razvand
pushed a commit
that referenced
this pull request
May 29, 2024
This change exposes Unikraft-internal syscalls that create sockets. Both versions returning raw uk_files as well as opened file descriptors are provided. Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Mihnea Firoiu <mihneafiroiu0@gmail.com> Reviewed-by: Radu Nichita <radunichita99@gmail.com> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #1337
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This change exposes Unikraft-internal syscalls that create sockets. Both versions returning raw uk_files as well as opened file descriptors are provided.
Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;Base target
Additional configuration
N/A