Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/vfscore: No-op mkmp on / #1376

Merged
merged 1 commit into from
Apr 4, 2024
Merged

lib/vfscore: No-op mkmp on / #1376

merged 1 commit into from
Apr 4, 2024

Conversation

mogasergiu
Copy link
Member

@mogasergiu mogasergiu commented Apr 3, 2024 •
edited
Loading

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran the checkpatch.uk on your commit series before opening this PR;
  • Updated relevant documentation.

Base target

  • Architecture(s): [N/A]
  • Platform(s): [N/A]
  • Application(s): [N/A]

Additional configuration

Description of changes

Issuing mkdir on / will result in ENOTDIR and it is also unnecessary. Therefore, add a check for this case so that we can ignore.

@mogasergiu mogasergiu requested a review from a team as a code owner April 3, 2024 11:01
@github-actions github-actions bot added area/lib Internal Unikraft Microlibrary lang/c Issues or PRs to do with C/C++ lib/vfscore VFS Core Interface labels Apr 3, 2024
@mogasergiu mogasergiu requested review from skuenzer and removed request for a team April 3, 2024 11:01
@mogasergiu
lib/vfscore: No-op mkmp on /
de951e6 
Issuing `mkdir` on `/` will result in `ENOTDIR` and it is also
unnecessary. Therefore, add a check for this case so that we can
ignore.

Signed-off-by: Sergiu Moga <sergiu@unikraft.io>
skuenzer
skuenzer approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@skuenzer skuenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this fix!

Reviewed-by: Simon Kuenzer simon@unikraft.io
Approved-by: Simon Kuenzer simon@unikraft.io

@skuenzer skuenzer changed the base branch from staging to staging-1376 April 4, 2024 14:20
@skuenzer skuenzer merged commit 2412a07 into unikraft:staging-1376 Apr 4, 2024
12 checks passed
skuenzer pushed a commit that referenced this pull request Apr 4, 2024
@mogasergiu @skuenzer
lib/vfscore: No-op mkmp on /
e12715a 
Issuing `mkdir` on `/` will result in `ENOTDIR` and it is also
unnecessary. Therefore, add a check for this case so that we can
ignore.

Signed-off-by: Sergiu Moga <sergiu@unikraft.io>
Approved-by: Simon Kuenzer <simon@unikraft.io>
Reviewed-by: Simon Kuenzer <simon@unikraft.io>
GitHub-Closes: #1376
SerbanSo pushed a commit to SerbanSo/unikraft-ASLR that referenced this pull request Jun 16, 2024
@mogasergiu @SerbanSo
lib/vfscore: No-op mkmp on /
8f165ae 
Issuing `mkdir` on `/` will result in `ENOTDIR` and it is also
unnecessary. Therefore, add a check for this case so that we can
ignore.

Signed-off-by: Sergiu Moga <sergiu@unikraft.io>
Approved-by: Simon Kuenzer <simon@unikraft.io>
Reviewed-by: Simon Kuenzer <simon@unikraft.io>
GitHub-Closes: unikraft#1376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skuenzer skuenzer skuenzer approved these changes

Assignees

@skuenzer skuenzer

Labels
area/lib Internal Unikraft Microlibrary lang/c Issues or PRs to do with C/C++ lib/vfscore VFS Core Interface
Projects
Unikraft Core Roadmap
Status: ✅ Done!
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mogasergiu @skuenzer