lib/posix-process: Add vfork & execve #1386
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arch/arm
arch/arm64
arch/x86_64
area/arch
nderjung
added
the
release-note
mogasergiu
requested changes
May 13, 2024
| { | ||
| execenv->regs.lr = ip; | ||
| execenv->regs.sp = sp; | ||
|
|
There was a problem hiding this comment.
I think we should also set spsr_el1 as I believe it to have an unsafe value coming from a mallocd stack. I would reuse the one of the parent and, additionally &= ~PSR_I so that IRQs are enblaed. Ditto for x86, let's reuse the parents flags but with IRQs forcefully enabled (although I think in both cases it should be safe to assume they are already enabled IMO).
There was a problem hiding this comment.
Actually, what is the reasoning for updating SPSR_EL1 and ESR_EL1 in ukarch_execenv_load?
lib/posix-process/clone.c
Outdated
| if ((flags & CLONE_VM)) { | ||
| if (!cl_args->stack && !cl_args->stack_size) { | ||
| uk_pr_debug("Using parent's sp @ 0x%lx\n", execenv->regs.rsp); | ||
| cl_args->stack = execenv->regs.rsp; /* FIXME */ |
There was a problem hiding this comment.
I assume FIXME cus x86 specific, right?
There was a problem hiding this comment.
Correct. I now included your patch with ukarch_regs_get_sp() to resolve this.
michpappas
force-pushed
the
michpappas/feature/vfork_execve
branch
3 times, most recently
from
9bfa6a7
to
e0a0f39
Compare
Add an architecture specific getter for the stack pointer of a `struct __regs`. Signed-off-by: Sergiu Moga <sergiu@unikraft.io>
libukbinfmt provides a minimal framework to register handlers of executable files. Typical examples include binary executables like ELF objects, or interpreted files like *nix scripts that use the sha-bang sequence to specify an interpreter. This commit only implements the functionality required to register and execute loaders within the kernel's scope. Additional functionality incl. application support via Linux's `binfmt_misc` API shall be added as a future extension. Checkpatch-Ignore: COMPLEX_MACRO Checkpatch-Ignore: MACRO_ARG_REUSE Signed-off-by: Michalis Pappas <michalis@unikraft.io>
Add definition of ARG_MAX to limits.h. POSIX defines ARG_MAX as the number of bytes available for the combined arguments and env vars of a new process. Whether that additionally includes NULL terminator, pointers, or alignment bytes is IMPLEMENTATION DEFINED. Signed-off-by: Michalis Pappas <michalis@unikraft.io>
Migrate the definitions of tid2pthread() and tid2pprocess() to the private process.h to make them available to the rest of the library. This requires to additionally migrate the definitions of struct posix_process() and struct posix_thread(). Signed-off-by: Michalis Pappas <michalis@unikraft.io>
The state provides information on whether a posix_thread is running, blocked, or exited. Notice that posix_thread_state is only updated by operations at the posix_process / posix_thread level and may not always be in sync with the state of the underlying uk_thread. This specifically applies to the POSIX_THREAD_RUNNING state, which may not be accurate e.g. if the underlying uk_thread blocks at the scheduler due to a lock. On the other hand, the variants of POSIX_STATE_BLOCKED always reflect the state of a posix_thread, as it is certain that the underlying uk_thread will also be blocked from the scheduler. Given the above, a check against POSIX_STATE_RUNNING should only be used to check if the state of a posix-thread is not terminated or blocked. Signed-off-by: Michalis Pappas <michalis@unikraft.io>
Add a field to posix_thread to keep track of its parent. This is populated during the creation of a posix_thread, and it is used for deriving the parent's state in execve() / exit(). Signed-off-by: Michalis Pappas <michalis@unikraft.io>
michpappas
force-pushed
the
michpappas/feature/vfork_execve
branch
from
e0a0f39
to
b36691a
Compare
Add implementation for execve(). For more info see execve(2). Requires a binfmt ELF loader. The default loader is provided by app-bincompat. Checkpatch-Ignore: AVOID_EXTERNS Signed-off-by: Michalis Pappas <michalis@unikraft.io>
vfork() sets the CLONE_VM and CLONE_VFORK flags. This triggers an error in the clone handlers of vfscore as CLONE_FS is not set. Update the handlers to additionally check against CLONE_VM, as that also implies that the parent and child share filesystem state. Signed-off-by: Michalis Pappas <michalis@unikraft.io>
The vfork() syscall is equivalent to calling clone() with the flags parameter set to CLONE_VM | CLONE_VFORK | SIGCHLD. Update clone() to support CLONE_VFORK and CLONE_VM. Implement vfork() as a wrapper of clone(). For more info see vfork(2). Signed-off-by: Michalis Pappas <michalis@unikraft.io>
michpappas
force-pushed
the
michpappas/feature/vfork_execve
branch
from
b36691a
to
b251f78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;Base target
Additional configuration
execve()syscallvfork()syscallukbinfmtlibraryDescription of changes
This PR adds support for
vfork()/execve()to libposix-process. This provides the foundation for running multiprocess applications on Unikraft.vfork()creates a child process that shares the same memory with the calling thread, including the stack. Uponvfork()the parent is suspended until the child callsexecve()or_exit()to prevent the parent's state from being corrupted. Due to above, the only permissible actions taken by the child are:pid_tto store its return value.exec(2)family, or_exit(2).Any action besides the above results into undefined behavior.
For a more elaborate description on
vfork()see vfork(2).execve()implements the standard behavior described in execve(2). To provide flexibility on the supported binary formats the implementation relies onlibukbinfmt, which is also introducedin this series. Similarly to linux, this provides a minimal framework for registering loaders that handle different binary formats, introducing the ability of loading interpreted scripts. The implementation may be extended with support for linux'sbinfmt_miscfs, should such a use-case arise. The implementation of the ELFukbinfmtloader is introduced inapp-elfloader.GitHub-Depends-On: #1316
GitHub-Depends-On: #1322
GitHub-Depends-On: #1346
GitHub-Depends-On: unikraft/app-elfloader#79