lib/ukvmem/arch/arm: Fix error_code build error with correct esr
#1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/lib
Commit 4d97341 ("lib/ukvmem/arch: Do not print error message if demand paging disabled") introduced a build error and a warning by copy-pasting the change from x86 to Arm. This is incorrect as the trap context from Arm does not have the `error_code` but the `esr` field instead. Fix this by using using the corect field and correct string format. Signed-off-by: Sergiu Moga <sergiu@unikraft.io>
mogasergiu
force-pushed
the
smoga/#1388/ukvmem_aa64_fix_esr_builderr
branch
from
5c86ce7
to
31eb2d1
Compare
StefanJum
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
All good, thanks.
Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com
razvand
approved these changes
Apr 20, 2024
razvand
pushed a commit
that referenced
this pull request
Apr 20, 2024
Commit 4d97341 ("lib/ukvmem/arch: Do not print error message if demand paging disabled") introduced a build error and a warning by copy-pasting the change from x86 to Arm. This is incorrect as the trap context from Arm does not have the `error_code` but the `esr` field instead. Fix this by using using the corect field and correct string format. Signed-off-by: Sergiu Moga <sergiu@unikraft.io> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #1388
ggracechoi
pushed a commit
to ggracechoi/unikraft
that referenced
this pull request
May 4, 2024
Commit 4d97341 ("lib/ukvmem/arch: Do not print error message if demand paging disabled") introduced a build error and a warning by copy-pasting the change from x86 to Arm. This is incorrect as the trap context from Arm does not have the `error_code` but the `esr` field instead. Fix this by using using the corect field and correct string format. Signed-off-by: Sergiu Moga <sergiu@unikraft.io> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: unikraft#1388
ggracechoi
pushed a commit
to ggracechoi/unikraft
that referenced
this pull request
May 4, 2024
Commit 4d97341 ("lib/ukvmem/arch: Do not print error message if demand paging disabled") introduced a build error and a warning by copy-pasting the change from x86 to Arm. This is incorrect as the trap context from Arm does not have the `error_code` but the `esr` field instead. Fix this by using using the corect field and correct string format. Signed-off-by: Sergiu Moga <sergiu@unikraft.io> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: unikraft#1388
SerbanSo
pushed a commit
to SerbanSo/unikraft-ASLR
that referenced
this pull request
Jun 16, 2024
Commit 4d97341 ("lib/ukvmem/arch: Do not print error message if demand paging disabled") introduced a build error and a warning by copy-pasting the change from x86 to Arm. This is incorrect as the trap context from Arm does not have the `error_code` but the `esr` field instead. Fix this by using using the corect field and correct string format. Signed-off-by: Sergiu Moga <sergiu@unikraft.io> Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: unikraft#1388
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 4d97341 ("lib/ukvmem/arch: Do not print error message if demand paging disabled") introduced a build error by copy-pasting the change from x86 to Arm. This is incorrect as the trap context from Arm does not have the
error_codebut theesrfield instead. Fix this by using using the corect field.Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;Base target
x86_64or N/A]kvm,xenor N/A]app-python3or N/A]Additional configuration
Description of changes