Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plat/linuxu: Adapt linuxu to new mrd fields #1420

Closed

Conversation

mschlumpp
Copy link
Member

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran the checkpatch.uk on your commit series before opening this PR;
  • Updated relevant documentation.

Base target

  • Architecture(s): N/A
  • Platform(s): linuxu
  • Application(s): N/A

Additional configuration

Description of changes

The commit introducing the fields, did not update the linuxu platform causing a crash on boot.

The commit introducing the fields, did not update the linuxu platform
causing a crash on boot.

Signed-off-by: Marco Schlumpp <marco@unikraft.io>
@mschlumpp mschlumpp requested a review from a team as a code owner May 22, 2024 08:28
@github-actions github-actions bot added area/plat Unikraft Patform lang/c Issues or PRs to do with C/C++ labels May 22, 2024
@mschlumpp
Copy link
Member Author

Given #1422 I think we can close this (except we want to have at least a bootable linuxu version in the history).
@skuenzer What do you think?

@skuenzer
Copy link
Member

Given #1422 I think we can close this (except we want to have at least a bootable linuxu version in the history). @skuenzer What do you think?

Hi @mschlumpp, yes, this is true. #1422 got even merged in the meantime. I am closing this PR. But nevertheless thanks for your work.

@skuenzer skuenzer closed this May 23, 2024
@mschlumpp mschlumpp deleted the mschlumpp/fix/linuxu-mrd branch May 23, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plat Unikraft Patform lang/c Issues or PRs to do with C/C++
Projects
Status: Done!
Development

Successfully merging this pull request may close these issues.

None yet

2 participants