support/qemu-guest: Enable RDRAND, RDSEED for x86 TCG #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QEMU's TCG for x86 can emulate `rdrand` and `rdseed` instructions as long as specified via `-cpu` parameter and QEMU 8.1.3 or newer is used. Due to recent requirements introduced with `lib/ukrandom` (see PR unikraft#1008, PR unikraft#1451), we request `rdseed` and `rdrand` when using TCG. Signed-off-by: Simon Kuenzer <simon@unikraft.io>
michpappas
approved these changes
Jun 15, 2024
There was a problem hiding this comment.
Looks good, thanks.
Reviewed-by: Michalis Pappas michalis@unikraft.io
razvand
approved these changes
Jun 15, 2024
unikraft-bot
pushed a commit
that referenced
this pull request
Jun 15, 2024
QEMU's TCG for x86 can emulate `rdrand` and `rdseed` instructions as long as specified via `-cpu` parameter and QEMU 8.1.3 or newer is used. Due to recent requirements introduced with `lib/ukrandom` (see PR #1008, PR #1451), we request `rdseed` and `rdrand` when using TCG. Signed-off-by: Simon Kuenzer <simon@unikraft.io> Reviewed-by: Michalis Pappas <michalis@unikraft.io> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #1459
unikraft-bot
added
ci/merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QEMU's TCG for x86 can emulate
rdrandandrdseedinstructions as long as specified via-cpuparameter and QEMU 8.1.3 or newer is used. Due to recent requirements introduced withlib/ukrandom(see PR #1008, PR #1451), we requestrdseedandrdrandwhen using TCG.